Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:fix réinitialisation du drawer après invitation #89 #212

Closed
wants to merge 3 commits into from
Closed

:fix réinitialisation du drawer après invitation #89 #212

wants to merge 3 commits into from

Conversation

dienamo
Copy link
Collaborator

@dienamo dienamo commented Nov 25, 2024 •
edited
Loading

Contrat du dev

Qualité

  • Relire le code
  • Relire le ticket
  • Recetter l'application
  • Regarder le commentaire de sonarcloud et corriger s'il est pertinent
  • Ajouter des variables d'environnement sur la production au besoin

Accessibilité

  • Vérifier l'accessibilité avec a11y.css
  • Vérifier l'accessibilité avec WAVE
  • Vérifier l'accessibilité avec Axe
  • Vérifier l'accessibilité avec headingMap
  • Vérifier le constraste en mode sombre

Facultatif mais fortement conseillé

  • Lancer les tests de mutation

Et n'oublie pas de vérifier ce que tu as fait en production !

@dienamo dienamo marked this pull request as ready for review November 26, 2024 07:44
@NerOcrO NerOcrO changed the title :fix réinitialisation du drawer après invitation :fix réinitialisation du drawer après invitation #89 Nov 26, 2024
@NerOcrO NerOcrO linked an issue Nov 26, 2024 that may be closed by this pull request
Inviter un gestionnaire à rejoindre la suite gestionnaire #89
Open
@dienamo dienamo force-pushed the fix-drawer-invitation-gestionnaire branch from 2821aa7 to 1b3fd6a Compare November 27, 2024 11:01
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
69.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@dienamo dienamo closed this Nov 27, 2024
@dienamo dienamo deleted the fix-drawer-invitation-gestionnaire branch November 27, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alezco Alezco Alezco approved these changes

@NerOcrO NerOcrO NerOcrO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inviter un gestionnaire à rejoindre la suite gestionnaire
3 participants
@dienamo @NerOcrO @Alezco